Commit 7fbeb95d authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe
Browse files

io_uring: add missing io_req_cancelled() 



fallocate_finish() is missing cancellation check. Add it.
It's safe to do that, as only flags setup and sqe fields copy are done
before it gets into __io_fallocate().

Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent db70e26e

fs/io_uring.c

+4 −0
Original line number Diff line number Diff line
@@ -2517,6 +2517,9 @@ static void io_fallocate_finish(struct io_wq_work **workptr) 
	struct io_kiocb *nxt = NULL;

	int ret;



	if (io_req_cancelled(req))

		return;



	ret = vfs_fallocate(req->file, req->sync.mode, req->sync.off,

				req->sync.len);

	if (ret < 0)
@@ -2904,6 +2907,7 @@ static void io_close_finish(struct io_wq_work **workptr) 
	struct io_kiocb *req = container_of(*workptr, struct io_kiocb, work);

	struct io_kiocb *nxt = NULL;



	/* not cancellable, don't do io_req_cancelled() */

	__io_close_finish(req, &nxt);

	if (nxt)

		io_wq_assign_next(workptr, nxt);

CRA Git | Maintained and supported by SUSTech CRA and CCSE