Commit 7faa33da authored Jul 22, 2011 by Tejun Heo Committed by Jeff Garzik Jan 08, 2012

ahci: start engine only during soft/hard resets



This is another attempt at fixing the same problem that 270dac35
(libata: ahci_start_engine compliant to AHCI spec) tried to solve.
Unfortunately, 270dac35 created regressions for a lot more common
controllers and got reverted.

This specific AHCI IP block becomes a brick if the DMA engine is
started while DRQ is set.  It is not possible to avoid the condition
completely but the most common occurrence is caused by spurious use of
ahci_start_engine() from ahci_start_port() during init sequence.

DMA engine is started after both soft and hard resets and
ahci_start_port() is always followed by resets, so there is no reason
to start DMA engine from ahci_start_port().

This patch removes ahci_start_engine() invocation from
ahci_start_port().  This change makes failure path of
ahci_port_suspend() leave engine stopped without following resets.
This is resolved by replacing ahci_start_port() call with
ata_port_freeze() which forces resets afterwards, which is the better
behavior anyway.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Brian Norris <computersforpeace@gmail.com>
Reported-by: Jian Peng <jipeng2005@gmail.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

parent 805a6af8

drivers/ata/libahci.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -746,9 +746,6 @@ static void ahci_start_port(struct ata_port *ap)
		/* enable FIS reception */
		ahci_start_fis_rx(ap);

		/* enable DMA */
		ahci_start_engine(ap);

		/* turn on LEDs */
		if (ap->flags & ATA_FLAG_EM) {
		ata_for_each_link(link, ap, EDGE) {
		@@ -2022,7 +2019,7 @@ static int ahci_port_suspend(struct ata_port *ap, pm_message_t mesg)
		ahci_power_down(ap);
		else {
		ata_port_err(ap, "%s (%d)\n", emsg, rc);
		ahci_start_port(ap);
		ata_port_freeze(ap);
		}

		return rc;

Admin message