Commit 7fa32329 authored by Shubhrajyoti Datta's avatar Shubhrajyoti Datta Committed by Wolfram Sang
Browse files

i2c: cadence: Move to sensible power management 



Currently the clocks are enabled at probe and disabled at remove.
Which keeps the clocks enabled even if no transaction is going on.
This patch enables the clocks at the start of transfer and disables
after it.

Also adapts to runtime pm.

converts dev pm to const to silence a checkpatch warning.

Signed-off-by: default avatarShubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
parent cfa576db

drivers/i2c/busses/i2c-cadence.c

+45 −21
Original line number Original line Diff line number Diff line
@@ -18,6 +18,7 @@ 
#include <linux/module.h>

#include <linux/module.h>

#include <linux/platform_device.h>

#include <linux/platform_device.h>

#include <linux/of.h>

#include <linux/of.h>

#include <linux/pm_runtime.h>





/* Register offsets for the I2C device. */

/* Register offsets for the I2C device. */

#define CDNS_I2C_CR_OFFSET		0x00 /* Control Register, RW */

#define CDNS_I2C_CR_OFFSET		0x00 /* Control Register, RW */
@@ -96,6 +97,8 @@ 
					 CDNS_I2C_IXR_COMP)

					 CDNS_I2C_IXR_COMP)





#define CDNS_I2C_TIMEOUT		msecs_to_jiffies(1000)

#define CDNS_I2C_TIMEOUT		msecs_to_jiffies(1000)

/* timeout for pm runtime autosuspend */

#define CNDS_I2C_PM_TIMEOUT		1000	/* ms */





#define CDNS_I2C_FIFO_DEPTH		16

#define CDNS_I2C_FIFO_DEPTH		16

/* FIFO depth at which the DATA interrupt occurs */

/* FIFO depth at which the DATA interrupt occurs */
@@ -141,6 +144,7 @@ 
 * @quirks:		flag for broken hold bit usage in r1p10

 * @quirks:		flag for broken hold bit usage in r1p10

 */

 */

struct cdns_i2c {

struct cdns_i2c {

	struct device		*dev;

	void __iomem *membase;

	void __iomem *membase;

	struct i2c_adapter adap;

	struct i2c_adapter adap;

	struct i2c_msg *p_msg;

	struct i2c_msg *p_msg;
@@ -569,9 +573,14 @@ static int cdns_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, 
	struct cdns_i2c *id = adap->algo_data;

	struct cdns_i2c *id = adap->algo_data;

	bool hold_quirk;

	bool hold_quirk;





	ret = pm_runtime_get_sync(id->dev);

	if (ret < 0)

		return ret;

	/* Check if the bus is free */

	/* Check if the bus is free */

	if (cdns_i2c_readreg(CDNS_I2C_SR_OFFSET) & CDNS_I2C_SR_BA)

	if (cdns_i2c_readreg(CDNS_I2C_SR_OFFSET) & CDNS_I2C_SR_BA) {

		return -EAGAIN;

		ret = -EAGAIN;

		goto out;

	}





	hold_quirk = !!(id->quirks & CDNS_I2C_BROKEN_HOLD_BIT);

	hold_quirk = !!(id->quirks & CDNS_I2C_BROKEN_HOLD_BIT);

	/*

	/*
@@ -590,7 +599,8 @@ static int cdns_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, 
			if (msgs[count].flags & I2C_M_RD) {

			if (msgs[count].flags & I2C_M_RD) {

				dev_warn(adap->dev.parent,

				dev_warn(adap->dev.parent,

					 "Can't do repeated start after a receive message\n");

					 "Can't do repeated start after a receive message\n");

				return -EOPNOTSUPP;

				ret = -EOPNOTSUPP;

				goto out;

			}

			}

		}

		}

		id->bus_hold_flag = 1;

		id->bus_hold_flag = 1;
@@ -608,20 +618,26 @@ static int cdns_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, 




		ret = cdns_i2c_process_msg(id, msgs, adap);

		ret = cdns_i2c_process_msg(id, msgs, adap);

		if (ret)

		if (ret)

			return ret;

			goto out;





		/* Report the other error interrupts to application */

		/* Report the other error interrupts to application */

		if (id->err_status) {

		if (id->err_status) {

			cdns_i2c_master_reset(adap);

			cdns_i2c_master_reset(adap);





			if (id->err_status & CDNS_I2C_IXR_NACK)

			if (id->err_status & CDNS_I2C_IXR_NACK) {

				return -ENXIO;

				ret = -ENXIO;



				goto out;

			return -EIO;

			}

			ret = -EIO;

			goto out;

		}

		}

	}

	}





	return num;

	ret = num;

out:

	pm_runtime_mark_last_busy(id->dev);

	pm_runtime_put_autosuspend(id->dev);

	return ret;

}

}





/**

/**
@@ -808,10 +824,9 @@ static int cdns_i2c_clk_notifier_cb(struct notifier_block *nb, unsigned long 
 *

 *

 * Return: 0 always

 * Return: 0 always

 */

 */

static int __maybe_unused cdns_i2c_suspend(struct device *_dev)

static int __maybe_unused cdns_i2c_runtime_suspend(struct device *dev)

{

{

	struct platform_device *pdev = container_of(_dev,

	struct platform_device *pdev = to_platform_device(dev);

			struct platform_device, dev);

	struct cdns_i2c *xi2c = platform_get_drvdata(pdev);

	struct cdns_i2c *xi2c = platform_get_drvdata(pdev);





	clk_disable(xi2c->clk);

	clk_disable(xi2c->clk);
@@ -828,16 +843,15 @@ static int __maybe_unused cdns_i2c_suspend(struct device *_dev) 
 *

 *

 * Return: 0 on success and error value on error

 * Return: 0 on success and error value on error

 */

 */

static int __maybe_unused cdns_i2c_resume(struct device *_dev)

static int __maybe_unused cdns_i2c_runtime_resume(struct device *dev)

{

{

	struct platform_device *pdev = container_of(_dev,

	struct platform_device *pdev = to_platform_device(dev);

			struct platform_device, dev);

	struct cdns_i2c *xi2c = platform_get_drvdata(pdev);

	struct cdns_i2c *xi2c = platform_get_drvdata(pdev);

	int ret;

	int ret;





	ret = clk_enable(xi2c->clk);

	ret = clk_enable(xi2c->clk);

	if (ret) {

	if (ret) {

		dev_err(_dev, "Cannot enable clock.\n");

		dev_err(dev, "Cannot enable clock.\n");

		return ret;

		return ret;

	}

	}
@@ -846,8 +860,10 @@ static int __maybe_unused cdns_i2c_resume(struct device *_dev) 
	return 0;

	return 0;

}

}





static SIMPLE_DEV_PM_OPS(cdns_i2c_dev_pm_ops, cdns_i2c_suspend,

static const struct dev_pm_ops cdns_i2c_dev_pm_ops = {

			 cdns_i2c_resume);

	SET_RUNTIME_PM_OPS(cdns_i2c_runtime_suspend,

			   cdns_i2c_runtime_resume, NULL)

};





static const struct cdns_platform_data r1p10_i2c_def = {

static const struct cdns_platform_data r1p10_i2c_def = {

	.quirks = CDNS_I2C_BROKEN_HOLD_BIT,

	.quirks = CDNS_I2C_BROKEN_HOLD_BIT,
@@ -881,6 +897,7 @@ static int cdns_i2c_probe(struct platform_device *pdev) 
	if (!id)

	if (!id)

		return -ENOMEM;

		return -ENOMEM;





	id->dev = &pdev->dev;

	platform_set_drvdata(pdev, id);

	platform_set_drvdata(pdev, id);





	match = of_match_node(cdns_i2c_of_match, pdev->dev.of_node);

	match = of_match_node(cdns_i2c_of_match, pdev->dev.of_node);
@@ -913,10 +930,14 @@ static int cdns_i2c_probe(struct platform_device *pdev) 
		return PTR_ERR(id->clk);

		return PTR_ERR(id->clk);

	}

	}

	ret = clk_prepare_enable(id->clk);

	ret = clk_prepare_enable(id->clk);

	if (ret) {

	if (ret)

		dev_err(&pdev->dev, "Unable to enable clock.\n");

		dev_err(&pdev->dev, "Unable to enable clock.\n");

		return ret;



	}

	pm_runtime_enable(id->dev);

	pm_runtime_set_autosuspend_delay(id->dev, CNDS_I2C_PM_TIMEOUT);

	pm_runtime_use_autosuspend(id->dev);

	pm_runtime_set_active(id->dev);



	id->clk_rate_change_nb.notifier_call = cdns_i2c_clk_notifier_cb;

	id->clk_rate_change_nb.notifier_call = cdns_i2c_clk_notifier_cb;

	if (clk_notifier_register(id->clk, &id->clk_rate_change_nb))

	if (clk_notifier_register(id->clk, &id->clk_rate_change_nb))

		dev_warn(&pdev->dev, "Unable to register clock notifier.\n");

		dev_warn(&pdev->dev, "Unable to register clock notifier.\n");
@@ -966,6 +987,8 @@ static int cdns_i2c_probe(struct platform_device *pdev) 




err_clk_dis:

err_clk_dis:

	clk_disable_unprepare(id->clk);

	clk_disable_unprepare(id->clk);

	pm_runtime_set_suspended(&pdev->dev);

	pm_runtime_disable(&pdev->dev);

	return ret;

	return ret;

}

}
@@ -984,6 +1007,7 @@ static int cdns_i2c_remove(struct platform_device *pdev) 
	i2c_del_adapter(&id->adap);

	i2c_del_adapter(&id->adap);

	clk_notifier_unregister(id->clk, &id->clk_rate_change_nb);

	clk_notifier_unregister(id->clk, &id->clk_rate_change_nb);

	clk_disable_unprepare(id->clk);

	clk_disable_unprepare(id->clk);

	pm_runtime_disable(&pdev->dev);





	return 0;

	return 0;

}

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE