clk: scmi: use devm_of_clk_add_hw_provider() API and drop scmi_clocks_remove (7f9badfc) · Commits · 戴 / test

Commit ("clk: Add devm_of_clk_add_hw_provider()/del_provider() APIs") adds devm_of_clk_add_hw_provider which takes care of deleting the clock provider when the clock providers device is removed. This patch makes use of devm_of_clk_add_hw_provider() instead of of_clk_add_hw_provider() so that we can eliminate the need of explicit scmi_clocks_remove for just doing of_clk_del_provider() Acked-by:

Stephen Boyd <sboyd@kernel.org> Signed-off-by:

Sudeep Holla <sudeep.holla@arm.com>

drivers/clk/clk-scmi.c

+2 −10

Original line number	Diff line number	Diff line
		@@ -172,15 +172,8 @@ static int scmi_clocks_probe(struct scmi_device *sdev)
		}
		}

		return of_clk_add_hw_provider(np, of_clk_hw_onecell_get, clk_data);
		}

		static void scmi_clocks_remove(struct scmi_device *sdev)
		{
		struct device *dev = &sdev->dev;
		struct device_node *np = dev->of_node;

		of_clk_del_provider(np);
		return devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get,
		clk_data);
		}

		static const struct scmi_device_id scmi_id_table[] = {
		@@ -192,7 +185,6 @@ MODULE_DEVICE_TABLE(scmi, scmi_id_table);
		static struct scmi_driver scmi_clocks_driver = {
		.name = "scmi-clocks",
		.probe = scmi_clocks_probe,
		.remove = scmi_clocks_remove,
		.id_table = scmi_id_table,
		};
		module_scmi_driver(scmi_clocks_driver);

Admin message