Commit 7f9584df authored May 14, 2018 by Andy Shevchenko Committed by Joerg Roedel May 15, 2018

iommu: Remove extra NULL check when call strtobool()



strtobool() does check for NULL parameter already. No need to repeat.

While here, switch to kstrtobool() and unshadow actual error code
(which is still -EINVAL).

No functional change intended.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>

parent 48e6f765

drivers/iommu/iommu.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -116,9 +116,11 @@ static void __iommu_detach_group(struct iommu_domain *domain,
		static int __init iommu_set_def_domain_type(char *str)
		{
		bool pt;
		int ret;

		if (!str \|\| strtobool(str, &pt))
		return -EINVAL;
		ret = kstrtobool(str, &pt);
		if (ret)
		return ret;

		iommu_def_domain_type = pt ? IOMMU_DOMAIN_IDENTITY : IOMMU_DOMAIN_DMA;
		return 0;

Admin message