scsi: qlogicpti: Use of_node_name_eq for node name comparisons (7f8e12f1) · Commits · 戴 / test

Convert string compares of DT node names to use of_node_name_eq helper instead. This removes direct access to the node name pointer. As prom_name is not used for anything else, remove it. Cc: "James E.J. Bottomley" <jejb@linux.ibm.com> Cc: "Martin K. Petersen" <martin.petersen@oracle.com> Cc: linux-scsi@vger.kernel.org Signed-off-by:

Rob Herring <robh@kernel.org> Signed-off-by:

Martin K. Petersen <martin.petersen@oracle.com>

drivers/scsi/qlogicpti.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1314,8 +1314,7 @@ static int qpti_sbus_probe(struct platform_device *op)
		qpti->qhost = host;
		qpti->op = op;
		qpti->qpti_id = nqptis;
		strcpy(qpti->prom_name, op->dev.of_node->name);
		qpti->is_pti = strcmp(qpti->prom_name, "QLGC,isp");
		qpti->is_pti = !of_node_name_eq(op->dev.of_node, "QLGC,isp");

		if (qpti_map_regs(qpti) < 0)
		goto fail_unlink;

drivers/scsi/qlogicpti.h

+1 −2

Original line number	Diff line number	Diff line
		@@ -364,7 +364,6 @@ struct qlogicpti {
		int qpti_id;
		int scsi_id;
		int prom_node;
		char prom_name[64];
		int irq;
		char differential, ultra, clock;
		unsigned char bursts;

Admin message