crypto: picoxcell - adjust the position of tasklet_init and fix missed tasklet_kill (7f8c36fe) · Commits · 戴 / test

Since tasklet is needed to be initialized before registering IRQ handler, adjust the position of tasklet_init to fix the wrong order. Besides, to fix the missed tasklet_kill, this patch adds a helper function and uses devm_add_action to kill the tasklet automatically. Fixes: ("crypto: picoxcell - add support for the picoxcell crypto engines") Signed-off-by:

Chuhong Yuan <hslester96@gmail.com> Signed-off-by:

Herbert Xu <herbert@gondor.apana.org.au>

drivers/crypto/picoxcell_crypto.c

+13 −2

Original line number	Diff line number	Diff line
		@@ -1595,6 +1595,11 @@ static const struct of_device_id spacc_of_id_table[] = {
		MODULE_DEVICE_TABLE(of, spacc_of_id_table);
		#endif /* CONFIG_OF */

		static void spacc_tasklet_kill(void *data)
		{
		tasklet_kill(data);
		}

		static int spacc_probe(struct platform_device *pdev)
		{
		int i, err, ret;
		@@ -1637,6 +1642,14 @@ static int spacc_probe(struct platform_device *pdev)
		return -ENXIO;
		}

		tasklet_init(&engine->complete, spacc_spacc_complete,
		(unsigned long)engine);

		ret = devm_add_action(&pdev->dev, spacc_tasklet_kill,
		&engine->complete);
		if (ret)
		return ret;

		if (devm_request_irq(&pdev->dev, irq->start, spacc_spacc_irq, 0,
		engine->name, engine)) {
		dev_err(engine->dev, "failed to request IRQ\n");
		@@ -1694,8 +1707,6 @@ static int spacc_probe(struct platform_device *pdev)
		INIT_LIST_HEAD(&engine->completed);
		INIT_LIST_HEAD(&engine->in_progress);
		engine->in_flight = 0;
		tasklet_init(&engine->complete, spacc_spacc_complete,
		(unsigned long)engine);

		platform_set_drvdata(pdev, engine);

Admin message