Commit 7f8b4ebe authored Nov 03, 2016 by Souptick Joarder Committed by Greg Kroah-Hartman Nov 10, 2016

serial: ioc4_serial: Free memory when kzalloc fails during probe

Inside ioc4_attach_local() 4 memory was allocated using kzalloc and
assign it to ports[] within loop. When kzalloc fails inside loop,
it returns error without freeing previously allocated memory and we
may have memory leak. Fix this by freeing ports[] before return.

Signed-off-by: Souptick joarder <jrdr.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 65dabaf5

drivers/tty/serial/ioc4_serial.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -1082,7 +1082,7 @@ static int inline ioc4_attach_local(struct ioc4_driver_data *idd)
		if (!port) {
		printk(KERN_WARNING
		"IOC4 serial memory not available for port\n");
		return -ENOMEM;
		goto free;
		}
		spin_lock_init(&port->ip_lock);

		@@ -1190,6 +1190,11 @@ static int inline ioc4_attach_local(struct ioc4_driver_data *idd)
		handle_dma_error_intr, port);
		}
		return 0;

		free:
		while (port_number)
		kfree(ports[--port_number]);
		return -ENOMEM;
		}

		/**

Admin message