Commit 7f81c889 authored Jun 15, 2011 by Michal Hocko Committed by Linus Torvalds Jun 15, 2011

fs/exec.c: use BUILD_BUG_ON for VM_STACK_FLAGS & VM_STACK_INCOMPLETE_SETUP



Commit a8bef8ff ("mm: migration: avoid race between shift_arg_pages()
and rmap_walk() during migration by not migrating temporary stacks")
introduced a BUG_ON() to ensure that VM_STACK_FLAGS and
VM_STACK_INCOMPLETE_SETUP do not overlap.  The check is a compile time
one, so BUILD_BUG_ON is more appropriate.

Signed-off-by: Michal Hocko <mhocko@suse.cz>
Cc: Mel Gorman <mel@csn.ul.ie>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent b0825ee3

fs/exec.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -277,7 +277,7 @@ static int __bprm_mm_init(struct linux_binprm *bprm)
		* use STACK_TOP because that can depend on attributes which aren't
		* configured yet.
		*/
		BUG_ON(VM_STACK_FLAGS & VM_STACK_INCOMPLETE_SETUP);
		BUILD_BUG_ON(VM_STACK_FLAGS & VM_STACK_INCOMPLETE_SETUP);
		vma->vm_end = STACK_TOP_MAX;
		vma->vm_start = vma->vm_end - PAGE_SIZE;
		vma->vm_flags = VM_STACK_FLAGS \| VM_STACK_INCOMPLETE_SETUP;

Admin message