Unverified Commit 7f807f28 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Mark Brown
Browse files

ASoC: wm_adsp: no need to check return value of debugfs_create functions 



When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: default avatarRichard Fitzgerald <rf@opensource.cirrus.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 0c888bab

sound/soc/codecs/wm_adsp.c

+7 −30
Original line number Diff line number Diff line
@@ -731,41 +731,18 @@ static void wm_adsp2_init_debugfs(struct wm_adsp *dsp, 
	struct dentry *root = NULL;

	int i;



	if (!component->debugfs_root) {

		adsp_err(dsp, "No codec debugfs root\n");

		goto err;

	}



	root = debugfs_create_dir(dsp->name, component->debugfs_root);



	if (!root)

		goto err;

	debugfs_create_bool("booted", 0444, root, &dsp->booted);

	debugfs_create_bool("running", 0444, root, &dsp->running);

	debugfs_create_x32("fw_id", 0444, root, &dsp->fw_id);

	debugfs_create_x32("fw_version", 0444, root, &dsp->fw_id_version);



	if (!debugfs_create_bool("booted", 0444, root, &dsp->booted))

		goto err;



	if (!debugfs_create_bool("running", 0444, root, &dsp->running))

		goto err;



	if (!debugfs_create_x32("fw_id", 0444, root, &dsp->fw_id))

		goto err;



	if (!debugfs_create_x32("fw_version", 0444, root, &dsp->fw_id_version))

		goto err;



	for (i = 0; i < ARRAY_SIZE(wm_adsp_debugfs_fops); ++i) {

		if (!debugfs_create_file(wm_adsp_debugfs_fops[i].name,

					 0444, root, dsp,

					 &wm_adsp_debugfs_fops[i].fops))

			goto err;

	}

	for (i = 0; i < ARRAY_SIZE(wm_adsp_debugfs_fops); ++i)

		debugfs_create_file(wm_adsp_debugfs_fops[i].name, 0444, root,

				    dsp, &wm_adsp_debugfs_fops[i].fops);



	dsp->debugfs_root = root;

	return;



err:

	debugfs_remove_recursive(root);

	adsp_err(dsp, "Failed to create debugfs\n");

}



static void wm_adsp2_cleanup_debugfs(struct wm_adsp *dsp)

CRA Git | Maintained and supported by SUSTech CRA and CCSE