Commit 7f7edefd authored Aug 12, 2019 by Maxim Mikityanskiy Committed by Saeed Mahameed Sep 05, 2019

net/mlx5e: Remove unnecessary clear_bit()s

Don't clear MLX5E_SQ_STATE_ENABLED on error in mlx5e_open_txqsq and
mlx5e_open_icosq, because it's not set there, and is 0 by default.

Fixes: acc6c595 ("net/mlx5e: Split open/close channels to stages")
Fixes: 9d18b514 ("net/mlx5e: Split open/close ICOSQ into stages")
Signed-off-by: Maxim Mikityanskiy <maximmi@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>

parent fa9e01c8

drivers/net/ethernet/mellanox/mlx5/core/en_main.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -1315,7 +1315,6 @@ static int mlx5e_open_txqsq(struct mlx5e_channel *c,
		return 0;

		err_free_txqsq:
		clear_bit(MLX5E_SQ_STATE_ENABLED, &sq->state);
		mlx5e_free_txqsq(sq);

		return err;
		@@ -1403,7 +1402,6 @@ int mlx5e_open_icosq(struct mlx5e_channel c, struct mlx5e_params params,
		return 0;

		err_free_icosq:
		clear_bit(MLX5E_SQ_STATE_ENABLED, &sq->state);
		mlx5e_free_icosq(sq);

		return err;

Admin message