Commit 7f7d9e1e authored Aug 11, 2020 by Lukasz Luba Committed by Krzysztof Kozlowski Aug 17, 2020

memory: samsung: exynos5422-dmc: Additional locking for 'curr_rate'



The 'curr_rate' is protected by local 'dmc->lock' in various places, but
not in a function exynos5_dmc_get_status(). The lock protects frequency
(and voltage) change process and the corresponding value stored in
'curr_rate'. Add the locking mechanism to protect the 'curr_rate' reading
also in the exynos5_dmc_get_status().

Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
Link: https://lore.kernel.org/r/20200811101727.3976-1-lukasz.luba@arm.com


Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

parent 9123e3a7

drivers/memory/samsung/exynos5422-dmc.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -908,7 +908,10 @@ static int exynos5_dmc_get_status(struct device *dev,
		int ret;

		if (dmc->in_irq_mode) {
		mutex_lock(&dmc->lock);
		stat->current_frequency = dmc->curr_rate;
		mutex_unlock(&dmc->lock);

		stat->busy_time = dmc->load;
		stat->total_time = dmc->total;
		} else {

Admin message