Commit 7f7d8fe2 authored Sep 11, 2013 by Jacek Anaszewski Committed by Mauro Carvalho Chehab Sep 24, 2013

[media] s5p-jpeg: Initialize vfd_decoder->vfl_dir field

This patch fixes regression introduced in commit 5c77879f
"[media] v4l2-dev: add new VFL_DIR_ defines" caused by not initializing
the vfl_dir field of the vfd_decoder instance of struct video_device,
after the field was introduced. It precluded calling the driver's ioctls
which require vfl_dir not to be equal to VFL_DIR_RX which is defined as
0 and uninitialized vfl_dir field is interpreted as such. In effect the
test in the v4l_s_fmt function failed for the ioctls that expect is_tx
to be false, which prevented the ioctl callbacks registered by the driver
from being called.

Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

parent 774d2301

drivers/media/platform/s5p-jpeg/jpeg-core.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1423,6 +1423,7 @@ static int s5p_jpeg_probe(struct platform_device *pdev)
		jpeg->vfd_decoder->release = video_device_release;
		jpeg->vfd_decoder->lock = &jpeg->lock;
		jpeg->vfd_decoder->v4l2_dev = &jpeg->v4l2_dev;
		jpeg->vfd_decoder->vfl_dir = VFL_DIR_M2M;

		ret = video_register_device(jpeg->vfd_decoder, VFL_TYPE_GRABBER, -1);
		if (ret) {

Admin message