Commit 7f6ac729 authored Oct 19, 2019 by Stephen Kitt Committed by Stephen Boyd Nov 08, 2019

clk/ti/adpll: allocate room for terminating null



The buffer allocated in ti_adpll_clk_get_name doesn't account for the
terminating null. This patch switches to devm_kasprintf to avoid
overflowing.

Signed-off-by: Stephen Kitt <steve@sk2.org>
Link: https://lkml.kernel.org/r/20191019140634.15596-1-steve@sk2.org


Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

parent 04932587

drivers/clk/ti/adpll.c

+2 −9

Original line number	Diff line number	Diff line
		@@ -194,15 +194,8 @@ static const char ti_adpll_clk_get_name(struct ti_adpll_data d,
		if (err)
		return NULL;
		} else {
		const char *base_name = "adpll";
		char *buf;

		buf = devm_kzalloc(d->dev, 8 + 1 + strlen(base_name) + 1 +
		strlen(postfix), GFP_KERNEL);
		if (!buf)
		return NULL;
		sprintf(buf, "%08lx.%s.%s", d->pa, base_name, postfix);
		name = buf;
		name = devm_kasprintf(d->dev, GFP_KERNEL, "%08lx.adpll.%s",
		d->pa, postfix);
		}

		return name;

Admin message