Commit 7f645462 authored Apr 30, 2020 by Wei Yongjun Committed by Daniel Borkmann Apr 30, 2020

bpf: Fix error return code in map_lookup_and_delete_elem()

Fix to return negative error code -EFAULT from the copy_to_user() error
handling case instead of 0, as done elsewhere in this function.

Fixes: bd513cd0 ("bpf: add MAP_LOOKUP_AND_DELETE_ELEM syscall")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20200430081851.166996-1-weiyongjun1@huawei.com

parent 18f02ad1

kernel/bpf/syscall.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1485,8 +1485,10 @@ static int map_lookup_and_delete_elem(union bpf_attr *attr)
		if (err)
		goto free_value;

		if (copy_to_user(uvalue, value, value_size) != 0)
		if (copy_to_user(uvalue, value, value_size) != 0) {
		err = -EFAULT;
		goto free_value;
		}

		err = 0;