Commit 7f566a91 authored by Hernán Gonzalez's avatar Hernán Gonzalez Committed by Jason Gunthorpe
Browse files

IB/qib: Move char *qib_sdma_state_names[] and constify while there. 



Note: This is compile only tested as I have no access to the hw.
This variable was not used in qib_sdma.c but in qib_iba7322.c. Declaring it
there, as static, saves 56 bytes.

add/remove: 0/2 grow/shrink: 0/0 up/down: 0/-144 (-144)
Function                                     old     new   delta
qib_sdma_state_names                          56       -     -56
qib_sdma_event_names                          88       -     -88
Total: Before=2874565, After=2874421, chg -0.01%

Signed-off-by: default avatarHernán Gonzalez <hernan@vanguardiasur.com.ar>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 4f1d5834

drivers/infiniband/hw/qib/qib.h

+0 −2
Original line number Diff line number Diff line
@@ -472,8 +472,6 @@ enum qib_sdma_events { 
	qib_sdma_event_e90_timer_tick,

};



extern char *qib_sdma_state_names[];



struct sdma_set_state_action {

	unsigned op_enable:1;

	unsigned op_intenable:1;

drivers/infiniband/hw/qib/qib_iba7322.c

+10 −0
Original line number Diff line number Diff line
@@ -463,6 +463,16 @@ static u8 ib_rate_to_delay[IB_RATE_120_GBPS + 1] = { 
	[IB_RATE_40_GBPS] = 1

};



static const char * const qib_sdma_state_names[] = {

	[qib_sdma_state_s00_hw_down]          = "s00_HwDown",

	[qib_sdma_state_s10_hw_start_up_wait] = "s10_HwStartUpWait",

	[qib_sdma_state_s20_idle]             = "s20_Idle",

	[qib_sdma_state_s30_sw_clean_up_wait] = "s30_SwCleanUpWait",

	[qib_sdma_state_s40_hw_clean_up_wait] = "s40_HwCleanUpWait",

	[qib_sdma_state_s50_hw_halt_wait]     = "s50_HwHaltWait",

	[qib_sdma_state_s99_running]          = "s99_Running",

};



#define IBA7322_LINKSPEED_SHIFT SYM_LSB(IBCStatusA_0, LinkSpeedActive)

#define IBA7322_LINKWIDTH_SHIFT SYM_LSB(IBCStatusA_0, LinkWidthActive)

drivers/infiniband/hw/qib/qib_sdma.c

+0 −10
Original line number Diff line number Diff line
@@ -54,16 +54,6 @@ MODULE_PARM_DESC(sdma_descq_cnt, "Number of SDMA descq entries"); 
#define SDMA_DESC_COUNT_LSB     16

#define SDMA_DESC_GEN_LSB       30



char *qib_sdma_state_names[] = {

	[qib_sdma_state_s00_hw_down]          = "s00_HwDown",

	[qib_sdma_state_s10_hw_start_up_wait] = "s10_HwStartUpWait",

	[qib_sdma_state_s20_idle]             = "s20_Idle",

	[qib_sdma_state_s30_sw_clean_up_wait] = "s30_SwCleanUpWait",

	[qib_sdma_state_s40_hw_clean_up_wait] = "s40_HwCleanUpWait",

	[qib_sdma_state_s50_hw_halt_wait]     = "s50_HwHaltWait",

	[qib_sdma_state_s99_running]          = "s99_Running",

};



/* declare all statics here rather than keep sorting */

static int alloc_sdma(struct qib_pportdata *);

static void sdma_complete(struct kref *);

CRA Git | Maintained and supported by SUSTech CRA and CCSE