Commit 7f559274 authored Dec 03, 2018 by Chris Chiu Committed by Benjamin Tissoires Dec 05, 2018

HID: input: support Microsoft wireless radio control hotkey



The ASUS laptops start to support the airplane mode radio management
to replace the original mechanism of airplane mode toggle hotkey.
On the ASUS P5440FF, it presents as a HID device connecting via
I2C, named i2c-AMPD0001. When pressing it, the Embedded Controller
send hid report via I2C and switch the airplane mode indicator LED
based on the status.

However, it's not working because it fails to be identified as a
hidinput device. It fails in hidinput_connect() due to the macro
IS_INPUT_APPLICATION doesn't have HID_GD_WIRELESS_RADIO_CTLS as
a legit application code.

It's easy to add the HID I2C vendor and product id to the quirk
list and apply HID_QUIRK_HIDINPUT_FORCE to make it work. But it
makes more sense to support it as a generic input application.

Signed-off-by: Chris Chiu <chiu@endlessm.com>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

parent 2fc00c1e

include/linux/hid.h

+2 −1

Original line number	Diff line number	Diff line
		@@ -840,7 +840,8 @@ static inline bool hid_is_using_ll_driver(struct hid_device *hdev,
		#define IS_INPUT_APPLICATION(a) \
		(((a >= HID_UP_GENDESK) && (a <= HID_GD_MULTIAXIS)) \
		\|\| ((a >= HID_DG_PEN) && (a <= HID_DG_WHITEBOARD)) \
		\|\| (a == HID_GD_SYSTEM_CONTROL) \|\| (a == HID_CP_CONSUMER_CONTROL))
		\|\| (a == HID_GD_SYSTEM_CONTROL) \|\| (a == HID_CP_CONSUMER_CONTROL) \
		\|\| (a == HID_GD_WIRELESS_RADIO_CTLS))

		/* HID core API */

Admin message