Commit 7f45a875 authored by Jan Kiszka's avatar Jan Kiszka Committed by Linus Walleij
Browse files

gpio: exar: Fix reading of directions and values 



First, the logic for translating a register bit to the return code of
exar_get_direction and exar_get_value were wrong. And second, there was
a flip regarding the register bank in exar_get_direction.

Signed-off-by: default avatarJan Kiszka <jan.kiszka@siemens.com>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 5dab5872

drivers/gpio/gpio-exar.c

+4 −4
Original line number Diff line number Diff line
@@ -68,7 +68,7 @@ static int exar_get(struct gpio_chip *chip, unsigned int reg) 
	value = readb(exar_gpio->regs + reg);

	mutex_unlock(&exar_gpio->lock);



	return !!value;

	return value;

}



static int exar_get_direction(struct gpio_chip *chip, unsigned int offset)
@@ -78,7 +78,7 @@ static int exar_get_direction(struct gpio_chip *chip, unsigned int offset) 
	int val;



	addr = bank ? EXAR_OFFSET_MPIOSEL_HI : EXAR_OFFSET_MPIOSEL_LO;

	val = exar_get(chip, addr) >> (offset % 8);

	val = exar_get(chip, addr) & BIT(offset % 8);



	return !!val;

}
@@ -89,8 +89,8 @@ static int exar_get_value(struct gpio_chip *chip, unsigned int offset) 
	unsigned int addr;

	int val;



	addr = bank ? EXAR_OFFSET_MPIOLVL_LO : EXAR_OFFSET_MPIOLVL_HI;

	val = exar_get(chip, addr) >> (offset % 8);

	addr = bank ? EXAR_OFFSET_MPIOLVL_HI : EXAR_OFFSET_MPIOLVL_LO;

	val = exar_get(chip, addr) & BIT(offset % 8);



	return !!val;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE