Commit 7f436b53 authored May 27, 2015 by Michael Neuling Committed by Michael Ellerman Jun 03, 2015

cxl: Fix error path on probe



When probing we call pci_enable_device() but don't call pci_disable_device() on
fail. This causes refcounting issues in the PCI subsystem if a second driver
tries to bind to the same device.

This patch adds the pci_disable_device() to the probe error path. This error
path is hit when this cxl driver tries to bind to AFUs (on the vPHB) rather
than the physical device.

Signed-off-by: Michael Neuling <mikey@neuling.org>
Acked-by: Ian Munsie <imunsie@au1.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

parent bee30c70

drivers/misc/cxl/pci.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1138,6 +1138,7 @@ static int cxl_probe(struct pci_dev dev, const struct pci_device_id id)
		adapter = cxl_init_adapter(dev);
		if (IS_ERR(adapter)) {
		dev_err(&dev->dev, "cxl_init_adapter failed: %li\n", PTR_ERR(adapter));
		pci_disable_device(dev);
		return PTR_ERR(adapter);
		}

Admin message