Commit 7f3697e2 authored by Jeff Layton's avatar Jeff Layton
Browse files

locks: fix unlock when fcntl_setlk races with a close 



Dmitry reported that he was able to reproduce the WARN_ON_ONCE that
fires in locks_free_lock_context when the flc_posix list isn't empty.

The problem turns out to be that we're basically rebuilding the
file_lock from scratch in fcntl_setlk when we discover that the setlk
has raced with a close. If the l_whence field is SEEK_CUR or SEEK_END,
then we may end up with fl_start and fl_end values that differ from
when the lock was initially set, if the file position or length of the
file has changed in the interim.

Fix this by just reusing the same lock request structure, and simply
override fl_type value with F_UNLCK as appropriate. That ensures that
we really are unlocking the lock that was initially set.

While we're there, make sure that we do pop a WARN_ON_ONCE if the
removal ever fails. Also return -EBADF in this event, since that's
what we would have returned if the close had happened earlier.

Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: <stable@vger.kernel.org>
Fixes: c293621b (stale POSIX lock handling)
Reported-by: default avatarDmitry Vyukov <dvyukov@google.com>
Signed-off-by: default avatarJeff Layton <jeff.layton@primarydata.com>
Acked-by: default avatar"J. Bruce Fields" <bfields@fieldses.org>
parent 91899226

fs/locks.c

+30 −21
Original line number Diff line number Diff line
@@ -2181,7 +2181,6 @@ int fcntl_setlk(unsigned int fd, struct file *filp, unsigned int cmd, 
		goto out;

	}



again:

	error = flock_to_posix_lock(filp, file_lock, &flock);

	if (error)

		goto out;
@@ -2223,19 +2222,22 @@ again: 
	 * Attempt to detect a close/fcntl race and recover by

	 * releasing the lock that was just acquired.

	 */

	if (!error && file_lock->fl_type != F_UNLCK) {

		/*

	 * we need that spin_lock here - it prevents reordering between

	 * update of i_flctx->flc_posix and check for it done in close().

	 * rcu_read_lock() wouldn't do.

		 * We need that spin_lock here - it prevents reordering between

		 * update of i_flctx->flc_posix and check for it done in

		 * close(). rcu_read_lock() wouldn't do.

		 */

		spin_lock(&current->files->file_lock);

		f = fcheck(fd);

		spin_unlock(&current->files->file_lock);

	if (!error && f != filp && flock.l_type != F_UNLCK) {

		flock.l_type = F_UNLCK;

		goto again;

		if (f != filp) {

			file_lock->fl_type = F_UNLCK;

			error = do_lock_file_wait(filp, cmd, file_lock);

			WARN_ON_ONCE(error);

			error = -EBADF;

		}

	}



out:

	locks_free_lock(file_lock);

	return error;
@@ -2321,7 +2323,6 @@ int fcntl_setlk64(unsigned int fd, struct file *filp, unsigned int cmd, 
		goto out;

	}



again:

	error = flock64_to_posix_lock(filp, file_lock, &flock);

	if (error)

		goto out;
@@ -2363,14 +2364,22 @@ again: 
	 * Attempt to detect a close/fcntl race and recover by

	 * releasing the lock that was just acquired.

	 */

	if (!error && file_lock->fl_type != F_UNLCK) {

		/*

		 * We need that spin_lock here - it prevents reordering between

		 * update of i_flctx->flc_posix and check for it done in

		 * close(). rcu_read_lock() wouldn't do.

		 */

		spin_lock(&current->files->file_lock);

		f = fcheck(fd);

		spin_unlock(&current->files->file_lock);

	if (!error && f != filp && flock.l_type != F_UNLCK) {

		flock.l_type = F_UNLCK;

		goto again;

		if (f != filp) {

			file_lock->fl_type = F_UNLCK;

			error = do_lock_file_wait(filp, cmd, file_lock);

			WARN_ON_ONCE(error);

			error = -EBADF;

		}

	}



out:

	locks_free_lock(file_lock);

	return error;

CRA Git | Maintained and supported by SUSTech CRA and CCSE