Commit 7f30830b authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: hda - Always resume the codec immediately 



This is a fix for the problem in commit 785f857d, the pop noise
issue on some machines with ALC269.  The problem was the uninitialized
state after the resume due to the delayed resume of the codec chips.
In that commit, we tried to fix by forcibly putting the codec to D3 at
suspend.  But, this still also leaves the uninitialized state after
resume, and it _might_ be still problematic with some BIOS.  Since the
commit turned out to regress another issues, we reverted it in the
end.

Now, in this fix, try to fix by turning on the codec immediately at
the resume path.  We need to take care of the power-saving in this
case.  When the device is woken up at the power-saved state, it should
go power-saving again after the resume.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent c382a9f0

sound/pci/hda/hda_codec.c

+7 −2
Original line number Diff line number Diff line
@@ -3500,6 +3500,10 @@ static void hda_call_codec_suspend(struct hda_codec *codec) 
 */

static void hda_call_codec_resume(struct hda_codec *codec)

{

	/* set as if powered on for avoiding re-entering the resume

	 * in the resume / power-save sequence

	 */

	hda_keep_power_on(codec);

	hda_set_power_state(codec,

			    codec->afg ? codec->afg : codec->mfg,

			    AC_PWRST_D0);
@@ -3515,6 +3519,7 @@ static void hda_call_codec_resume(struct hda_codec *codec) 
		snd_hda_codec_resume_amp(codec);

		snd_hda_codec_resume_cache(codec);

	}

	snd_hda_power_down(codec); /* flag down before returning */

}

#endif /* CONFIG_PM */
@@ -4332,6 +4337,7 @@ void snd_hda_power_up(struct hda_codec *codec) 
	snd_hda_update_power_acct(codec);

	codec->power_on = 1;

	codec->power_jiffies = jiffies;

	codec->power_transition = 1; /* avoid reentrance */

	if (bus->ops.pm_notify)

		bus->ops.pm_notify(bus);

	hda_call_codec_resume(codec);
@@ -5521,7 +5527,6 @@ int snd_hda_resume(struct hda_bus *bus) 
	list_for_each_entry(codec, &bus->codec_list, list) {

		if (codec->patch_ops.pre_resume)

			codec->patch_ops.pre_resume(codec);

		if (snd_hda_codec_needs_resume(codec))

		hda_call_codec_resume(codec);

	}

	return 0;

sound/pci/hda/hda_codec.h

+0 −2
Original line number Diff line number Diff line
@@ -1051,12 +1051,10 @@ const char *snd_hda_get_jack_location(u32 cfg); 
#ifdef CONFIG_SND_HDA_POWER_SAVE

void snd_hda_power_up(struct hda_codec *codec);

void snd_hda_power_down(struct hda_codec *codec);

#define snd_hda_codec_needs_resume(codec) codec->power_count

void snd_hda_update_power_acct(struct hda_codec *codec);

#else

static inline void snd_hda_power_up(struct hda_codec *codec) {}

static inline void snd_hda_power_down(struct hda_codec *codec) {}

#define snd_hda_codec_needs_resume(codec) 1

#endif



#ifdef CONFIG_SND_HDA_PATCH_LOADER

sound/pci/hda/hda_intel.c

+1 −13
Original line number Diff line number Diff line
@@ -2351,17 +2351,6 @@ static void azx_power_notify(struct hda_bus *bus) 
 * power management

 */



static int snd_hda_codecs_inuse(struct hda_bus *bus)

{

	struct hda_codec *codec;



	list_for_each_entry(codec, &bus->codec_list, list) {

		if (snd_hda_codec_needs_resume(codec))

			return 1;

	}

	return 0;

}



static int azx_suspend(struct pci_dev *pci, pm_message_t state)

{

	struct snd_card *card = pci_get_drvdata(pci);
@@ -2408,7 +2397,6 @@ static int azx_resume(struct pci_dev *pci) 
		return -EIO;

	azx_init_pci(chip);



	if (snd_hda_codecs_inuse(chip->bus))

	azx_init_chip(chip, 1);



	snd_hda_resume(chip->bus);

CRA Git | Maintained and supported by SUSTech CRA and CCSE