Commit 7f2a83f1 authored by Huacai Chen's avatar Huacai Chen Committed by Paolo Bonzini
Browse files

KVM: MIPS: Add CPUCFG emulation for Loongson-3 



Loongson-3 overrides lwc2 instructions to implement CPUCFG and CSR
read/write functions. These instructions all cause guest exit so CSR
doesn't benifit KVM guest (and there are always legacy methods to
provide the same functions as CSR). So, we only emulate CPUCFG and let
it return a reduced feature list (which means the virtual CPU doesn't
have any other advanced features, including CSR) in KVM.

Reviewed-by: default avatarAleksandar Markovic <aleksandar.qemu.devel@gmail.com>
Signed-off-by: default avatarHuacai Chen <chenhc@lemote.com>
Co-developed-by: default avatarJiaxun Yang <jiaxun.yang@flygoat.com>
Message-Id: <1590220602-3547-12-git-send-email-chenhc@lemote.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent f21db309

arch/mips/include/asm/kvm_host.h

+3 −0
Original line number Diff line number Diff line
@@ -173,6 +173,9 @@ struct kvm_vcpu_stat { 
	u64 vz_ghfc_exits;

	u64 vz_gpa_exits;

	u64 vz_resvd_exits;

#ifdef CONFIG_CPU_LOONGSON64

	u64 vz_cpucfg_exits;

#endif

#endif

	u64 halt_successful_poll;

	u64 halt_attempted_poll;

arch/mips/include/uapi/asm/inst.h

+11 −0
Original line number Diff line number Diff line
@@ -1012,6 +1012,16 @@ struct loongson3_lsdc2_format { /* Loongson-3 overridden ldc2/sdc2 Load/Store fo 
	;))))))

};



struct loongson3_lscsr_format {	/* Loongson-3 CPUCFG&CSR read/write format */

	__BITFIELD_FIELD(unsigned int opcode : 6,

	__BITFIELD_FIELD(unsigned int rs : 5,

	__BITFIELD_FIELD(unsigned int fr : 5,

	__BITFIELD_FIELD(unsigned int rd : 5,

	__BITFIELD_FIELD(unsigned int fd : 5,

	__BITFIELD_FIELD(unsigned int func : 6,

	;))))))

};



/*

 * MIPS16e instruction formats (16-bit length)

 */
@@ -1114,6 +1124,7 @@ union mips_instruction { 
	struct mm16_r5_format mm16_r5_format;

	struct loongson3_lswc2_format loongson3_lswc2_format;

	struct loongson3_lsdc2_format loongson3_lsdc2_format;

	struct loongson3_lscsr_format loongson3_lscsr_format;

};



union mips16e_instruction {

arch/mips/kvm/mips.c

+1 −0
Original line number Diff line number Diff line
@@ -67,6 +67,7 @@ struct kvm_stats_debugfs_item debugfs_entries[] = { 
	VCPU_STAT("vz_ghfc", vz_ghfc_exits),

	VCPU_STAT("vz_gpa", vz_gpa_exits),

	VCPU_STAT("vz_resvd", vz_resvd_exits),

	VCPU_STAT("vz_cpucfg", vz_cpucfg_exits),

#endif

	VCPU_STAT("halt_successful_poll", halt_successful_poll),

	VCPU_STAT("halt_attempted_poll", halt_attempted_poll),

arch/mips/kvm/vz.c

+77 −0
Original line number Diff line number Diff line
@@ -29,6 +29,7 @@ 
#include <linux/kvm_host.h>



#include "interrupt.h"

#include "loongson_regs.h"



#include "trace.h"
@@ -1092,6 +1093,77 @@ static enum emulation_result kvm_vz_gpsi_cache(union mips_instruction inst, 
	return EMULATE_FAIL;

}



#ifdef CONFIG_CPU_LOONGSON64

static enum emulation_result kvm_vz_gpsi_lwc2(union mips_instruction inst,

					      u32 *opc, u32 cause,

					      struct kvm_run *run,

					      struct kvm_vcpu *vcpu)

{

	unsigned int rs, rd;

	unsigned int hostcfg;

	unsigned long curr_pc;

	enum emulation_result er = EMULATE_DONE;



	/*

	 * Update PC and hold onto current PC in case there is

	 * an error and we want to rollback the PC

	 */

	curr_pc = vcpu->arch.pc;

	er = update_pc(vcpu, cause);

	if (er == EMULATE_FAIL)

		return er;



	rs = inst.loongson3_lscsr_format.rs;

	rd = inst.loongson3_lscsr_format.rd;

	switch (inst.loongson3_lscsr_format.fr) {

	case 0x8:  /* Read CPUCFG */

		++vcpu->stat.vz_cpucfg_exits;

		hostcfg = read_cpucfg(vcpu->arch.gprs[rs]);



		switch (vcpu->arch.gprs[rs]) {

		case LOONGSON_CFG0:

			vcpu->arch.gprs[rd] = 0x14c000;

			break;

		case LOONGSON_CFG1:

			hostcfg &= (LOONGSON_CFG1_FP | LOONGSON_CFG1_MMI |

				    LOONGSON_CFG1_MSA1 | LOONGSON_CFG1_MSA2 |

				    LOONGSON_CFG1_SFBP);

			vcpu->arch.gprs[rd] = hostcfg;

			break;

		case LOONGSON_CFG2:

			hostcfg &= (LOONGSON_CFG2_LEXT1 | LOONGSON_CFG2_LEXT2 |

				    LOONGSON_CFG2_LEXT3 | LOONGSON_CFG2_LSPW);

			vcpu->arch.gprs[rd] = hostcfg;

			break;

		case LOONGSON_CFG3:

			vcpu->arch.gprs[rd] = hostcfg;

			break;

		default:

			/* Don't export any other advanced features to guest */

			vcpu->arch.gprs[rd] = 0;

			break;

		}

		break;



	default:

		kvm_err("lwc2 emulate not impl %d rs %lx @%lx\n",

			inst.loongson3_lscsr_format.fr, vcpu->arch.gprs[rs], curr_pc);

		er = EMULATE_FAIL;

		break;

	}



	/* Rollback PC only if emulation was unsuccessful */

	if (er == EMULATE_FAIL) {

		kvm_err("[%#lx]%s: unsupported lwc2 instruction 0x%08x 0x%08x\n",

			curr_pc, __func__, inst.word, inst.loongson3_lscsr_format.fr);



		vcpu->arch.pc = curr_pc;

	}



	return er;

}

#endif



static enum emulation_result kvm_trap_vz_handle_gpsi(u32 cause, u32 *opc,

						     struct kvm_vcpu *vcpu)

{
@@ -1120,6 +1192,11 @@ static enum emulation_result kvm_trap_vz_handle_gpsi(u32 cause, u32 *opc, 
		trace_kvm_exit(vcpu, KVM_TRACE_EXIT_CACHE);

		er = kvm_vz_gpsi_cache(inst, opc, cause, run, vcpu);

		break;

#endif

#ifdef CONFIG_CPU_LOONGSON64

	case lwc2_op:

		er = kvm_vz_gpsi_lwc2(inst, opc, cause, run, vcpu);

		break;

#endif

	case spec3_op:

		switch (inst.spec3_format.func) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE