PCI: Add pci_info_ratelimited() to ratelimit PCI separately (7f1c62c4) · Commits · 戴 / test

Do not use printk_ratelimit() in drivers/pci/pci.c as it shares the rate limiting state with all other callers to the printk_ratelimit(). Add pci_info_ratelimited() (similar to pci_notice_ratelimited() added in the commit ("vfio: Use dev_printk() when possible")) and use it instead of printk_ratelimit() + pci_info(). Link: https://lore.kernel.org/r/20190825224616.8021-1-kw@linux.com Signed-off-by:

Krzysztof Wilczynski <kw@linux.com> Signed-off-by:

Bjorn Helgaas <bhelgaas@google.com>

drivers/pci/pci.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -890,8 +890,8 @@ static int pci_raw_set_power_state(struct pci_dev *dev, pci_power_t state)

		pci_read_config_word(dev, dev->pm_cap + PCI_PM_CTRL, &pmcsr);
		dev->current_state = (pmcsr & PCI_PM_CTRL_STATE_MASK);
		if (dev->current_state != state && printk_ratelimit())
		pci_info(dev, "Refused to change power state, currently in D%d\n",
		if (dev->current_state != state)
		pci_info_ratelimited(dev, "Refused to change power state, currently in D%d\n",
		dev->current_state);

		/*

include/linux/pci.h

+3 −0

Original line number	Diff line number	Diff line
		@@ -2433,4 +2433,7 @@ void pci_uevent_ers(struct pci_dev *pdev, enum pci_ers_result err_type);
		#define pci_notice_ratelimited(pdev, fmt, arg...) \
		dev_notice_ratelimited(&(pdev)->dev, fmt, ##arg)

		#define pci_info_ratelimited(pdev, fmt, arg...) \
		dev_info_ratelimited(&(pdev)->dev, fmt, ##arg)

		#endif /* LINUX_PCI_H */

Admin message