Commit 7f07e5f1 authored Mar 26, 2019 by Claudiu Manoil Committed by David S. Miller Mar 27, 2019

net: mii: Fix PAUSE cap advertisement from linkmode_adv_to_lcl_adv_t() helper



With a recent link mode advertisement code update this helper
providing local pause capability translation used for flow
control link mode negotiation got broken.
For eth drivers using this helper, the issue is apparent only
if either PAUSE or ASYM_PAUSE is being advertised.

Fixes: 3c1bcc86 ("net: ethernet: Convert phydev advertize and supported from u32 to link mode")
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 669efc76

include/linux/mii.h

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -469,7 +469,7 @@ static inline u32 linkmode_adv_to_lcl_adv_t(unsigned long *advertising)
	if (linkmode_test_bit(ETHTOOL_LINK_MODE_Pause_BIT,		if (linkmode_test_bit(ETHTOOL_LINK_MODE_Pause_BIT,
	advertising))		advertising))
	lcl_adv \|= ADVERTISE_PAUSE_CAP;		lcl_adv \|= ADVERTISE_PAUSE_CAP;
	if (linkmode_test_bit(ETHTOOL_LINK_MODE_Pause_BIT,		if (linkmode_test_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,
	advertising))		advertising))
	lcl_adv \|= ADVERTISE_PAUSE_ASYM;		lcl_adv \|= ADVERTISE_PAUSE_ASYM;

Admin message