Commit 7efcce04 authored May 25, 2018 by Sergio Paracuellos Committed by Greg Kroah-Hartman Jun 01, 2018

staging: mt7621-gpio: avoid locking in mediatek_gpio_get_direction



mediatek_gpio_get_direction function is holding across a simple read
which it seems to be not neccessary at all. Just remove this locking
cleaning code of this function a bit.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Reviewed-by: NeilBrown <neil@brown.name>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent e119216d

drivers/staging/mt7621-gpio/gpio-mt7621.c

+1 −6

Original line number	Diff line number	Diff line
		@@ -129,12 +129,7 @@ static int
		mediatek_gpio_get_direction(struct gpio_chip *chip, unsigned int offset)
		{
		struct mtk_gc *rg = to_mediatek_gpio(chip);
		unsigned long flags;
		u32 t;

		spin_lock_irqsave(&rg->lock, flags);
		t = mtk_gpio_r32(rg, GPIO_REG_CTRL);
		spin_unlock_irqrestore(&rg->lock, flags);
		u32 t = mtk_gpio_r32(rg, GPIO_REG_CTRL);

		return (t & BIT(offset)) ? 0 : 1;
		}

Admin message