Commit 7ef1fc57 authored Aug 24, 2020 by Dinghao Liu Committed by David S. Miller Aug 24, 2020

net: systemport: Fix memleak in bcm_sysport_probe



When devm_kcalloc() fails, dev should be freed just
like what we've done in the subsequent error paths.

Fixes: 7b78be48 ("net: systemport: Dynamically allocate number of TX rings")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 100e3345

drivers/net/ethernet/broadcom/bcmsysport.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -2491,8 +2491,10 @@ static int bcm_sysport_probe(struct platform_device *pdev)
		priv->tx_rings = devm_kcalloc(&pdev->dev, txq,
		sizeof(struct bcm_sysport_tx_ring),
		GFP_KERNEL);
		if (!priv->tx_rings)
		return -ENOMEM;
		if (!priv->tx_rings) {
		ret = -ENOMEM;
		goto err_free_netdev;
		}

		priv->is_lite = params->is_lite;
		priv->num_rx_desc_words = params->num_rx_desc_words;

Admin message