net/x25: handle additional netdev events (7eed751b) · Commits · 戴 / test

1. Add / remove x25_link_device by NETDEV_REGISTER/UNREGISTER and also by NETDEV_POST_TYPE_CHANGE/NETDEV_PRE_TYPE_CHANGE. This change is needed so that the x25_neigh struct for an interface is already created when it shows up and is kept independently if the interface goes UP or DOWN. This is used in an upcomming commit, where x25 params of an neighbour will get configurable through ioctls. 2. NETDEV_CHANGE event makes it possible to handle carrier loss and detection. If carrier is lost, clean up everything related to this neighbour by calling x25_link_terminated(). 3. Also call x25_link_terminated() for NETDEV_DOWN events and remove the call to x25_clear_forward_by_dev() in x25_route_device_down(), as this is already called by x25_kill_by_neigh() which gets called by x25_link_terminated(). 4. Do nothing for NETDEV_UP and NETDEV_GOING_DOWN events, as these will be handled in layer 2 (LAPB) and layer3 (X.25) will be informed by layer2 when layer2 link is established and layer3 link should be initiated. Signed-off-by:

Martin Schiller <ms@dev.tdt.de> Signed-off-by:

Jakub Kicinski <kuba@kernel.org>

net/x25/af_x25.c

+16 −6

Original line number	Diff line number	Diff line
		@@ -233,21 +233,31 @@ static int x25_device_event(struct notifier_block *this, unsigned long event,
		#endif
		) {
		switch (event) {
		case NETDEV_UP:
		case NETDEV_REGISTER:
		case NETDEV_POST_TYPE_CHANGE:
		x25_link_device_up(dev);
		break;
		case NETDEV_GOING_DOWN:
		case NETDEV_DOWN:
		nb = x25_get_neigh(dev);
		if (nb) {
		x25_terminate_link(nb);
		x25_link_terminated(nb);
		x25_neigh_put(nb);
		}
		break;
		case NETDEV_DOWN:
		x25_kill_by_device(dev);
		x25_route_device_down(dev);
		break;
		case NETDEV_PRE_TYPE_CHANGE:
		case NETDEV_UNREGISTER:
		x25_link_device_down(dev);
		break;
		case NETDEV_CHANGE:
		if (!netif_carrier_ok(dev)) {
		nb = x25_get_neigh(dev);
		if (nb) {
		x25_link_terminated(nb);
		x25_neigh_put(nb);
		}
		}
		break;
		}
		}

net/x25/x25_link.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -232,6 +232,9 @@ void x25_link_established(struct x25_neigh *nb)
		void x25_link_terminated(struct x25_neigh *nb)
		{
		nb->state = X25_LINK_STATE_0;
		skb_queue_purge(&nb->queue);
		x25_stop_t20timer(nb);

		/* Out of order: clear existing virtual calls (X.25 03/93 4.6.3) */
		x25_kill_by_neigh(nb);
		}
		@@ -277,9 +280,6 @@ void x25_link_device_up(struct net_device *dev)
		*/
		static void __x25_remove_neigh(struct x25_neigh *nb)
		{
		skb_queue_purge(&nb->queue);
		x25_stop_t20timer(nb);

		if (nb->node.next) {
		list_del(&nb->node);
		x25_neigh_put(nb);

net/x25/x25_route.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -115,9 +115,6 @@ void x25_route_device_down(struct net_device *dev)
		__x25_remove_route(rt);
		}
		write_unlock_bh(&x25_route_list_lock);

		/* Remove any related forwarding */
		x25_clear_forward_by_dev(dev);
		}

		/*

Admin message