Commit 7ee98e1b authored by Evan Quan's avatar Evan Quan Committed by Alex Deucher
Browse files

drm/amd/pm: drop unnecessary smu_baco->mutex lock protections(V2) 



As these operations are performed in hardware setup and there
is actually no race conditions during this period considering:
1. the hardware setup is serial and cannot be in parallel
2. all other operations can be performed only after hardware
   setup complete.

V2: rich the commit log description

Signed-off-by: default avatarEvan Quan <evan.quan@amd.com>
Acked-by: default avatarNirmoy Das <nirmoy.das@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent b66effb1

drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c

+0 −2
Original line number Diff line number Diff line
@@ -386,11 +386,9 @@ static int arcturus_check_powerplay_table(struct smu_context *smu) 
		table_context->power_play_table;

	struct smu_baco_context *smu_baco = &smu->smu_baco;



	mutex_lock(&smu_baco->mutex);

	if (powerplay_table->platform_caps & SMU_11_0_PP_PLATFORM_CAP_BACO ||

	    powerplay_table->platform_caps & SMU_11_0_PP_PLATFORM_CAP_MACO)

		smu_baco->platform_support = true;

	mutex_unlock(&smu_baco->mutex);



	table_context->thermal_controller_type =

		powerplay_table->thermal_controller_type;

drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c

+0 −2
Original line number Diff line number Diff line
@@ -336,11 +336,9 @@ static int navi10_check_powerplay_table(struct smu_context *smu) 
	if (powerplay_table->platform_caps & SMU_11_0_PP_PLATFORM_CAP_HARDWAREDC)

		smu->dc_controlled_by_gpio = true;



	mutex_lock(&smu_baco->mutex);

	if (powerplay_table->platform_caps & SMU_11_0_PP_PLATFORM_CAP_BACO ||

	    powerplay_table->platform_caps & SMU_11_0_PP_PLATFORM_CAP_MACO)

		smu_baco->platform_support = true;

	mutex_unlock(&smu_baco->mutex);



	table_context->thermal_controller_type =

		powerplay_table->thermal_controller_type;

drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c

+0 −2
Original line number Diff line number Diff line
@@ -298,11 +298,9 @@ static int sienna_cichlid_check_powerplay_table(struct smu_context *smu) 
		table_context->power_play_table;

	struct smu_baco_context *smu_baco = &smu->smu_baco;



	mutex_lock(&smu_baco->mutex);

	if (powerplay_table->platform_caps & SMU_11_0_7_PP_PLATFORM_CAP_BACO ||

	    powerplay_table->platform_caps & SMU_11_0_7_PP_PLATFORM_CAP_MACO)

		smu_baco->platform_support = true;

	mutex_unlock(&smu_baco->mutex);



	table_context->thermal_controller_type =

		powerplay_table->thermal_controller_type;

drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c

+1 −6
Original line number Diff line number Diff line
@@ -1426,13 +1426,8 @@ static int smu_v11_0_baco_set_armd3_sequence(struct smu_context *smu, enum smu_v 
bool smu_v11_0_baco_is_support(struct smu_context *smu)

{

	struct smu_baco_context *smu_baco = &smu->smu_baco;

	bool baco_support;



	mutex_lock(&smu_baco->mutex);

	baco_support = smu_baco->platform_support;

	mutex_unlock(&smu_baco->mutex);



	if (!baco_support)

	if (!smu_baco->platform_support)

		return false;



	/* Arcturus does not support this bit mask */

CRA Git | Maintained and supported by SUSTech CRA and CCSE