Commit 7ee78aff authored Jun 24, 2020 by Colin Ian King Committed by Alex Deucher Jul 01, 2020

drm/radeon: fix array out-of-bounds read and write issues



There is an off-by-one bounds check on the index into arrays
table->mc_reg_address and table->mc_reg_table_entry[k].mc_data[j] that
can lead to reads and writes outside of arrays. Fix the bound checking
off-by-one error.

Addresses-Coverity: ("Out-of-bounds read/write")
Fixes: cc8dbbb4 ("drm/radeon: add dpm support for CI dGPUs (v2)")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent 57f01856

drivers/gpu/drm/radeon/ci_dpm.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -4351,7 +4351,7 @@ static int ci_set_mc_special_registers(struct radeon_device *rdev,
		table->mc_reg_table_entry[k].mc_data[j] \|= 0x100;
		}
		j++;
		if (j > SMU7_DISCRETE_MC_REGISTER_ARRAY_SIZE)
		if (j >= SMU7_DISCRETE_MC_REGISTER_ARRAY_SIZE)
		return -EINVAL;

		if (!pi->mem_gddr5) {

Admin message