Commit 7eb74ff8 authored Aug 20, 2018 by Mitch Williams Committed by Jeff Kirsher Aug 30, 2018

i40e: use correct length for strncpy



Caught by GCC 8. When we provide a length for strncpy, we should not
include the terminating null. So we must tell it one less than the size
of the destination buffer.

Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent 3c818910

drivers/net/ethernet/intel/i40e/i40e_ptp.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -694,7 +694,8 @@ static long i40e_ptp_create_clock(struct i40e_pf *pf)
		if (!IS_ERR_OR_NULL(pf->ptp_clock))
		return 0;

		strncpy(pf->ptp_caps.name, i40e_driver_name, sizeof(pf->ptp_caps.name));
		strncpy(pf->ptp_caps.name, i40e_driver_name,
		sizeof(pf->ptp_caps.name) - 1);
		pf->ptp_caps.owner = THIS_MODULE;
		pf->ptp_caps.max_adj = 999999999;
		pf->ptp_caps.n_ext_ts = 0;

Admin message