powerpc/ps3: Fix SMP lockdep boot warning (7eaf09ee) · Commits · 戴 / test

Move the PS3 IPI message setup from ps3_smp_setup_cpu() to ps3_smp_probe(). Fixes startup warnings like these: ------------[ cut here ]------------ WARNING: at kernel/lockdep.c:2649 Modules linked in: ... ---[ end trace 31fd0ba7d8756001 ]--- Signed-off-by:

Geoff Levand <geoff@infradead.org> Signed-off-by:

Benjamin Herrenschmidt <benh@kernel.crashing.org>

arch/powerpc/platforms/ps3/smp.c

+32 −32

Original line number	Diff line number	Diff line
		@@ -59,11 +59,9 @@ static void ps3_smp_message_pass(int cpu, int msg)

		static int ps3_smp_probe(void)
		{
		return 2;
		}
		int cpu;

		static void __init ps3_smp_setup_cpu(int cpu)
		{
		for (cpu = 0; cpu < 2; cpu++) {
		int result;
		unsigned int *virqs = per_cpu(ps3_ipi_virqs, cpu);
		int i;
		@@ -103,6 +101,9 @@ static void __init ps3_smp_setup_cpu(int cpu)
		DBG(" <- %s:%d: (%d)\n", __func__, __LINE__, cpu);
		}

		return 2;
		}

		void ps3_smp_cleanup_cpu(int cpu)
		{
		unsigned int *virqs = per_cpu(ps3_ipi_virqs, cpu);
		@@ -123,7 +124,6 @@ static struct smp_ops_t ps3_smp_ops = {
		.probe = ps3_smp_probe,
		.message_pass = ps3_smp_message_pass,
		.kick_cpu = smp_generic_kick_cpu,
		.setup_cpu = ps3_smp_setup_cpu,
		};

		void smp_init_ps3(void)

Admin message