Commit 7eaecf79 authored Jan 18, 2020 by Florian Westphal Committed by Pablo Neira Ayuso Jan 18, 2020

netfilter: nft_osf: add missing check for DREG attribute



syzbot reports just another NULL deref crash because of missing test
for presence of the attribute.

Reported-by:  <syzbot+cf23983d697c26c34f60@syzkaller.appspotmail.com>
Fixes:  b96af92d ("netfilter: nf_tables: implement Passive OS fingerprint module in nft_osf")
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

parent e02d9c4c

net/netfilter/nft_osf.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -61,6 +61,9 @@ static int nft_osf_init(const struct nft_ctx *ctx,
		int err;
		u8 ttl;

		if (!tb[NFTA_OSF_DREG])
		return -EINVAL;

		if (tb[NFTA_OSF_TTL]) {
		ttl = nla_get_u8(tb[NFTA_OSF_TTL]);
		if (ttl > 2)

Admin message