Commit 7e92e1d7 authored by Markus Stockhausen's avatar Markus Stockhausen Committed by NeilBrown
Browse files

md/raid6 algorithms: improve test program 



It is always helpful to have a test tool in place if we implement
new data critical algorithms. So add some test routines to the raid6
checker that can prove if the new xor_syndrome() works as expected.

Run through all permutations of start/stop pages per algorithm and
simulate a xor_syndrome() assisted rmw run. After each rmw check if
the recovery algorithm still confirms that the stripe is fine.

Signed-off-by: default avatarMarkus Stockhausen <stockhausen@collogia.de>
Signed-off-by: default avatarNeilBrown <neilb@suse.de>
parent fe5cbc6e

lib/raid6/test/test.c

+36 −15
Original line number Diff line number Diff line
@@ -28,11 +28,11 @@ char *dataptrs[NDISKS]; 
char data[NDISKS][PAGE_SIZE];

char recovi[PAGE_SIZE], recovj[PAGE_SIZE];



static void makedata(void)

static void makedata(int start, int stop)

{

	int i, j;



	for (i = 0; i < NDISKS; i++) {

	for (i = start; i <= stop; i++) {

		for (j = 0; j < PAGE_SIZE; j++)

			data[i][j] = rand();
@@ -91,21 +91,24 @@ int main(int argc, char *argv[]) 
{

	const struct raid6_calls *const *algo;

	const struct raid6_recov_calls *const *ra;

	int i, j;

	int i, j, p1, p2;

	int err = 0;



	makedata();

	makedata(0, NDISKS-1);



	for (ra = raid6_recov_algos; *ra; ra++) {

		if ((*ra)->valid  && !(*ra)->valid())

			continue;



		raid6_2data_recov = (*ra)->data2;

		raid6_datap_recov = (*ra)->datap;



		printf("using recovery %s\n", (*ra)->name);



		for (algo = raid6_algos; *algo; algo++) {

			if (!(*algo)->valid || (*algo)->valid()) {

			if ((*algo)->valid && !(*algo)->valid())

				continue;



			raid6_call = **algo;



			/* Nuke syndromes */
@@ -118,7 +121,25 @@ int main(int argc, char *argv[]) 
			for (i = 0; i < NDISKS-1; i++)

				for (j = i+1; j < NDISKS; j++)

					err += test_disks(i, j);



			if (!raid6_call.xor_syndrome)

				continue;



			for (p1 = 0; p1 < NDISKS-2; p1++)

				for (p2 = p1; p2 < NDISKS-2; p2++) {



					/* Simulate rmw run */

					raid6_call.xor_syndrome(NDISKS, p1, p2, PAGE_SIZE,

								(void **)&dataptrs);

					makedata(p1, p2);

					raid6_call.xor_syndrome(NDISKS, p1, p2, PAGE_SIZE,

                                                                (void **)&dataptrs);



					for (i = 0; i < NDISKS-1; i++)

						for (j = i+1; j < NDISKS; j++)

							err += test_disks(i, j);

				}



		}

		printf("\n");

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE