Commit 7e8d7e3c authored Jul 07, 2005 by KAMBAROV, ZAUR Committed by Linus Torvalds Jul 07, 2005

[PATCH] coverity: sunrpc/xprt task null check



In __xprt_lock_write() we check to see if `task' is NULL, but in other places
we just go and dereference it.

`task' shouldn't be NULL anyway, so remove this test.

This defect was found automatically by Coverity Prevent, a static analysis
tool.

Signed-off-by: Zaur Kambarov <zkambarov@coverity.com>
Acked-by: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Neil Brown <neilb@cse.unsw.edu.au>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 7eaae282

net/sunrpc/xprt.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -145,8 +145,6 @@ __xprt_lock_write(struct rpc_xprt xprt, struct rpc_task task)
		if (test_and_set_bit(XPRT_LOCKED, &xprt->sockstate)) {
		if (task == xprt->snd_task)
		return 1;
		if (task == NULL)
		return 0;
		goto out_sleep;
		}
		if (xprt->nocong \|\| __xprt_get_cong(xprt, task)) {

Admin message