Commit 7e882481 authored Sep 09, 2014 by Andrey Vagin Committed by Linus Torvalds Sep 10, 2014

fs/notify: don't show f_handle if exportfs_encode_inode_fh failed

Currently we handle only ENOSPC.  In case of other errors the file_handle
variable isn't filled properly and we will show a part of stack.

Signed-off-by: Andrey Vagin <avagin@openvz.org>
Acked-by: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 1fc98d11

fs/notify/fdinfo.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -50,7 +50,7 @@ static int show_mark_fhandle(struct seq_file m, struct inode inode)
		size = f.handle.handle_bytes >> 2;

		ret = exportfs_encode_inode_fh(inode, (struct fid *)f.handle.f_handle, &size, 0);
		if ((ret == FILEID_INVALID) \|\| (ret == -ENOSPC)) {
		if ((ret == FILEID_INVALID) \|\| (ret < 0)) {
		WARN_ONCE(1, "Can't encode file handler for inotify: %d\n", ret);
		return 0;
		}

Admin message