Commit 7e78c875 authored by liuyang34's avatar liuyang34 Committed by Paul Moore
Browse files

selinuxfs: use scnprintf to get real length for inode 



The return value of snprintf maybe over the size of TMPBUFLEN, use
scnprintf instead in sel_read_class and sel_read_perm.

Signed-off-by: default avatarliuyang34 <liuyang34@xiaomi.com>
[PM: cleaned up the description]
Signed-off-by: default avatarPaul Moore <paul@paul-moore.com>
parent f1268534

security/selinux/selinuxfs.c

+2 −2
Original line number Diff line number Diff line
@@ -1728,7 +1728,7 @@ static ssize_t sel_read_class(struct file *file, char __user *buf, 
{

	unsigned long ino = file_inode(file)->i_ino;

	char res[TMPBUFLEN];

	ssize_t len = snprintf(res, sizeof(res), "%d", sel_ino_to_class(ino));

	ssize_t len = scnprintf(res, sizeof(res), "%d", sel_ino_to_class(ino));

	return simple_read_from_buffer(buf, count, ppos, res, len);

}
@@ -1742,7 +1742,7 @@ static ssize_t sel_read_perm(struct file *file, char __user *buf, 
{

	unsigned long ino = file_inode(file)->i_ino;

	char res[TMPBUFLEN];

	ssize_t len = snprintf(res, sizeof(res), "%d", sel_ino_to_perm(ino));

	ssize_t len = scnprintf(res, sizeof(res), "%d", sel_ino_to_perm(ino));

	return simple_read_from_buffer(buf, count, ppos, res, len);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE