Commit 7e6fc2f5 authored Jan 07, 2019 by Daniel Drake Committed by Thomas Gleixner Jan 11, 2019

x86/kaslr: Fix incorrect i8254 outb() parameters



The outb() function takes parameters value and port, in that order.  Fix
the parameters used in the kalsr i8254 fallback code.

Fixes: 5bfce5ef ("x86, kaslr: Provide randomness functions")
Signed-off-by: Daniel Drake <drake@endlessm.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: bp@alien8.de
Cc: hpa@zytor.com
Cc: linux@endlessm.com
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/20190107034024.15005-1-drake@endlessm.com

parent 5962dd22

arch/x86/lib/kaslr.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -36,8 +36,8 @@ static inline u16 i8254(void)
		u16 status, timer;

		do {
		outb(I8254_PORT_CONTROL,
		I8254_CMD_READBACK \| I8254_SELECT_COUNTER0);
		outb(I8254_CMD_READBACK \| I8254_SELECT_COUNTER0,
		I8254_PORT_CONTROL);
		status = inb(I8254_PORT_COUNTER0);
		timer = inb(I8254_PORT_COUNTER0);
		timer \|= inb(I8254_PORT_COUNTER0) << 8;

Admin message