Commit 7e6cfb54 authored Sep 29, 2008 by Boaz Harrosh Committed by Jens Axboe Sep 29, 2008

scsi: fix fall out of sg-chaining patch in qlogicpti



Boaz writes:

"I've reviewed all patches since Matthew's, and I find one small
problem.

In the load_cmd() there is a compound loop where the first 4 sg's are
set then the rest are set into a memory structure in group of 7 sg's.

Well the second 7-group and on is a bug because sg pointer does not advance.
This is a fall out from Jens's patch."

The reporter, Meelis Roos <mroos@ut.ee>, verified that this patch
does indeed fix his problem with qlogicpti.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>

parent 6ef190cc

drivers/scsi/qlogicpti.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -914,6 +914,7 @@ static inline int load_cmd(struct scsi_cmnd Cmnd, struct Command_Entry cmd,
		ds[i].d_count = sg_dma_len(s);
		}
		sg_count -= n;
		sg = s;
		}
		} else {
		cmd->dataseg[0].d_base = 0;

Admin message