Commit 7e6086d9 authored Aug 05, 2012 by Shawn Guo Committed by Linus Walleij Aug 07, 2012

gpio/mxc: specify gpio base for device tree probe



Currently, unlike the non-DT probe where the gpio base is specified
with pdev->id, the DT probe uses the base dynamically allocated by
gpio core, which uses a completely different numbering scheme.  This
causes two issues to user space applications which access sysfs entry
/sys/class/gpio/gpioN.

* It breaks the compatibility with user space applications between
  non-DT and DT kernels.

* It's not intuitive and sometimes hard for users to map the Linux
  gpio number to the actual hardware pin.

Use alias to identify the gpio port/bank, and then the gpio base
can be specified with port id to solve above issues.  If alias is not
defined in device tree, the base number dynamically allocated by gpio
core will be used.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Tested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent f6b0ca25

drivers/gpio/gpio-mxc.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -465,7 +465,8 @@ static int __devinit mxc_gpio_probe(struct platform_device *pdev)
		goto out_iounmap;

		port->bgc.gc.to_irq = mxc_gpio_to_irq;
		port->bgc.gc.base = pdev->id * 32;
		port->bgc.gc.base = (pdev->id < 0) ? of_alias_get_id(np, "gpio") * 32 :
		pdev->id * 32;

		err = gpiochip_add(&port->bgc.gc);
		if (err)

Admin message