Commit 7e52440c authored Sep 06, 2019 by Colin Ian King Committed by Martin K. Petersen Sep 30, 2019

scsi: ufs: make array setup_attrs static const, makes object smaller

Don't populate the array setup_attrs on the stack but instead make it
static const. Makes the object code smaller by 180 bytes.

Before:
   text	   data	    bss	    dec	    hex	filename
   2140	    224	      0	   2364	    93c	drivers/scsi/ufs/ufshcd-dwc.o

After:
   text	   data	    bss	    dec	    hex	filename
   1863	    320	      0	   2183	    887	drivers/scsi/ufs/ufshcd-dwc.o

(gcc version 9.2.1, amd64)

Link: https://lore.kernel.org/r/20190906170104.10450-1-colin.king@canonical.com


Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 5ece56a2

drivers/scsi/ufs/ufshcd-dwc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -80,7 +80,7 @@ static int ufshcd_dwc_link_is_up(struct ufs_hba *hba)
		*/
		static int ufshcd_dwc_connection_setup(struct ufs_hba *hba)
		{
		const struct ufshcd_dme_attr_val setup_attrs[] = {
		static const struct ufshcd_dme_attr_val setup_attrs[] = {
		{ UIC_ARG_MIB(T_CONNECTIONSTATE), 0, DME_LOCAL },
		{ UIC_ARG_MIB(N_DEVICEID), 0, DME_LOCAL },
		{ UIC_ARG_MIB(N_DEVICEID_VALID), 0, DME_LOCAL },

Admin message