Commit 7e11577e authored by Lucas Stach's avatar Lucas Stach Committed by Greg Kroah-Hartman
Browse files

serial: imx: re-enable DMA support without hardware flow control 



The commit enabling DMA support even if no flow control is present
was reverted on the grounds that it uncovered a number of bugs in
the code that lead to hanging tty devices and/or missing characters.

After tracking down the issues it is clear that those were generic
bugs and had nothing to do with flow control being present or not,
only that allowing DMA without hardware flow control increased
the exposure of that code a lot.

Now that those bugs are fixed, it should be safe to re-enable DMA
support.

Signed-off-by: default avatarLucas Stach <l.stach@pengutronix.de>
Acked-by: default avatarJiada Wang <jiada_wang@mentor.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 905c0dec

drivers/tty/serial/imx.c

+8 −7
Original line number Diff line number Diff line
@@ -1125,6 +1125,11 @@ static int imx_startup(struct uart_port *port) 


	writel(temp & ~UCR4_DREN, sport->port.membase + UCR4);



	/* Can we enable the DMA support? */

	if (is_imx6q_uart(sport) && !uart_console(port) &&

	    !sport->dma_is_inited)

		imx_uart_dma_init(sport);



	spin_lock_irqsave(&sport->port.lock, flags);

	/* Reset fifo's and state machines */

	i = 100;
@@ -1142,6 +1147,9 @@ static int imx_startup(struct uart_port *port) 
	writel(USR1_RTSD, sport->port.membase + USR1);

	writel(USR2_ORE, sport->port.membase + USR2);



	if (sport->dma_is_inited && !sport->dma_is_enabled)

		imx_enable_dma(sport);



	temp = readl(sport->port.membase + UCR1);

	temp |= UCR1_RRDYEN | UCR1_RTSDEN | UCR1_UARTEN;
@@ -1312,11 +1320,6 @@ imx_set_termios(struct uart_port *port, struct ktermios *termios, 
			} else {

				ucr2 |= UCR2_CTSC;

			}



			/* Can we enable the DMA support? */

			if (is_imx6q_uart(sport) && !uart_console(port)

				&& !sport->dma_is_inited)

				imx_uart_dma_init(sport);

		} else {

			termios->c_cflag &= ~CRTSCTS;

		}
@@ -1433,8 +1436,6 @@ imx_set_termios(struct uart_port *port, struct ktermios *termios, 
	if (UART_ENABLE_MS(&sport->port, termios->c_cflag))

		imx_enable_ms(&sport->port);



	if (sport->dma_is_inited && !sport->dma_is_enabled)

		imx_enable_dma(sport);

	spin_unlock_irqrestore(&sport->port.lock, flags);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE