mt76x02: do not enable RTS/CTS by default (7dfc45e6) · Commits · 戴 / test

My commit ("mt76x02: set protection according to ht operation element") enabled by default RTS/CTS protection for OFDM and CCK traffic, because MT_TX_RTS_CFG_THRESH is configured to non 0xffff by initvals and .set_rts_threshold callback is not called by mac80211 on initialization, only on user request or during ieee80211_reconfig() (suspend/resuem or restart_hw). Enabling RTS/CTS cause some problems when sending probe request frames by hcxdumptool penetration tool, but I expect it can cause other issues on different scenarios. Restore previous setting of RTS/CTS being disabled by default for OFDM/CCK by changing MT_TX_RTS_CFG_THRESH initvals to 0xffff. Fixes: ("mt76x02: set protection according to ht operation element") Signed-off-by:

Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by:

Kalle Valo <kvalo@codeaurora.org>

drivers/net/wireless/mediatek/mt76/mt76x0/initvals.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -46,7 +46,7 @@ static const struct mt76_reg_pair common_mac_reg_table[] = {
		{ MT_MM20_PROT_CFG, 0x01742004 },
		{ MT_MM40_PROT_CFG, 0x03f42084 },
		{ MT_TXOP_CTRL_CFG, 0x0000583f },
		{ MT_TX_RTS_CFG, 0x00092b20 },
		{ MT_TX_RTS_CFG, 0x00ffff20 },
		{ MT_EXP_ACK_TIME, 0x002400ca },
		{ MT_TXOP_HLDR_ET, 0x00000002 },
		{ MT_XIFS_TIME_CFG, 0x33a41010 },

drivers/net/wireless/mediatek/mt76/mt76x2/init.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -106,7 +106,7 @@ void mt76_write_mac_initvals(struct mt76x02_dev *dev)
		{ MT_TX_SW_CFG1, 0x00010000 },
		{ MT_TX_SW_CFG2, 0x00000000 },
		{ MT_TXOP_CTRL_CFG, 0x0400583f },
		{ MT_TX_RTS_CFG, 0x00100020 },
		{ MT_TX_RTS_CFG, 0x00ffff20 },
		{ MT_TX_TIMEOUT_CFG, 0x000a2290 },
		{ MT_TX_RETRY_CFG, 0x47f01f0f },
		{ MT_EXP_ACK_TIME, 0x002c00dc },

drivers/net/wireless/mediatek/mt76/mt76x2/usb_mac.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -93,7 +93,6 @@ int mt76x2u_mac_reset(struct mt76x02_dev *dev)
		mt76_wr(dev, MT_TX_LINK_CFG, 0x1020);
		mt76_wr(dev, MT_AUTO_RSP_CFG, 0x13);
		mt76_wr(dev, MT_MAX_LEN_CFG, 0x2f00);
		mt76_wr(dev, MT_TX_RTS_CFG, 0x92b20);

		mt76_wr(dev, MT_WMM_AIFSN, 0x2273);
		mt76_wr(dev, MT_WMM_CWMIN, 0x2344);

Admin message