Commit 7de8d238 authored Apr 10, 2019 by Pierre-Louis Bossart Committed by Vinod Koul Apr 14, 2019

soundwire: remove useless initializations



No need for explicit initialization of page and ssp fields, they are
already zeroed with a memset.

Detected with cppcheck:

[drivers/soundwire/bus.c:309]: (style) Variable 'msg->page' is
reassigned a value before the old one has been used.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent 4ac5627a

drivers/soundwire/bus.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -271,8 +271,6 @@ int sdw_fill_msg(struct sdw_msg msg, struct sdw_slave slave,
		msg->dev_num = dev_num;
		msg->flags = flags;
		msg->buf = buf;
		msg->ssp_sync = false;
		msg->page = false;

		if (addr < SDW_REG_NO_PAGE) { /* no paging area */
		return 0;

Admin message