pnfs-obj: Better IO pattern in case of unaligned offset (7de6e284) · Commits · 戴 / test

Depending on layout and ARCH, ORE has some limits on max IO sizes which is communicated on (what else) ore_layout->max_io_length, which is always stripe aligned. This was considered as the pg_test boundary for splitting and starting a new IO. But in the case of a long IO where the start offset is not aligned what would happen is that both end of IO[N] and start of IO[N+1] would be unaligned, causing each IO boundary parity unit to be calculated and written twice. So what we do in this patch is split the very start of an unaligned IO, up to a stripe boundary, and then next IO's can continue fully aligned til the end. We might be sacrificing the case where the full unaligned IO would fit within a single max_io_length, but the sacrifice is well worth the elimination of double calculation and parity units IO. Actually the sacrificing is marginal and is almost unmeasurable. TODO: If we know the total expected linear segment that will be received, at pg_init, we could use that information in many places: 1. blocks-layout get_layout write segment size 2. Better mds-threshold 3. In above situation for a better clean split I will do this in future submission. Signed-off-by:

Boaz Harrosh <bharrosh@panasas.com> Signed-off-by:

Trond Myklebust <Trond.Myklebust@netapp.com>

fs/nfs/objlayout/objio_osd.c

+52 −3

Original line number	Diff line number	Diff line
		@@ -570,17 +570,66 @@ static bool objio_pg_test(struct nfs_pageio_descriptor *pgio,
		return false;

		return pgio->pg_count + req->wb_bytes <=
		(unsigned long)pgio->pg_layout_private;
		}

		void objio_init_read(struct nfs_pageio_descriptor pgio, struct nfs_page req)
		{
		pnfs_generic_pg_init_read(pgio, req);
		if (unlikely(pgio->pg_lseg == NULL))
		return; /* Not pNFS */

		pgio->pg_layout_private = (void *)
		OBJIO_LSEG(pgio->pg_lseg)->layout.max_io_length;
		}

		static bool aligned_on_raid_stripe(u64 offset, struct ore_layout *layout,
		unsigned long *stripe_end)
		{
		u32 stripe_off;
		unsigned stripe_size;

		if (layout->raid_algorithm == PNFS_OSD_RAID_0)
		return true;

		stripe_size = layout->stripe_unit *
		(layout->group_width - layout->parity);

		div_u64_rem(offset, stripe_size, &stripe_off);
		if (!stripe_off)
		return true;

		*stripe_end = stripe_size - stripe_off;
		return false;
		}

		void objio_init_write(struct nfs_pageio_descriptor pgio, struct nfs_page req)
		{
		unsigned long stripe_end = 0;

		pnfs_generic_pg_init_write(pgio, req);
		if (unlikely(pgio->pg_lseg == NULL))
		return; /* Not pNFS */

		if (req->wb_offset \|\|
		!aligned_on_raid_stripe(req->wb_index * PAGE_SIZE,
		&OBJIO_LSEG(pgio->pg_lseg)->layout,
		&stripe_end)) {
		pgio->pg_layout_private = (void *)stripe_end;
		} else {
		pgio->pg_layout_private = (void *)
		OBJIO_LSEG(pgio->pg_lseg)->layout.max_io_length;
		}
		}

		static const struct nfs_pageio_ops objio_pg_read_ops = {
		.pg_init = pnfs_generic_pg_init_read,
		.pg_init = objio_init_read,
		.pg_test = objio_pg_test,
		.pg_doio = pnfs_generic_pg_readpages,
		};

		static const struct nfs_pageio_ops objio_pg_write_ops = {
		.pg_init = pnfs_generic_pg_init_write,
		.pg_init = objio_init_write,
		.pg_test = objio_pg_test,
		.pg_doio = pnfs_generic_pg_writepages,
		};

Admin message