Commit 7ddede6a authored Apr 21, 2016 by Jon Hunter Committed by Mark Brown Apr 22, 2016

regulator: core: Don't terminate supply resolution early



The function regulator_register_resolve_supply() is called from the
context of class_for_each_dev() (during the regulator registration) to
resolve any supplies added. regulator_register_resolve_supply() will
return an error if a regulator's supply cannot be resolved and this will
terminate the loop in class_for_each_dev(). This means that we will not
attempt to resolve any other supplies after one has failed. Hence, this
may delay the resolution of other regulator supplies until the failing
one itself can be resolved.

Rather than terminating the loop early, don't return an error code and
keep attempting to resolve any other supplies for regulators that have
been registered.

Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent a2151374

drivers/regulator/core.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -3842,7 +3842,12 @@ static void rdev_init_debugfs(struct regulator_dev *rdev)

		static int regulator_register_resolve_supply(struct device dev, void data)
		{
		return regulator_resolve_supply(dev_to_rdev(dev));
		struct regulator_dev *rdev = dev_to_rdev(dev);

		if (regulator_resolve_supply(rdev))
		rdev_dbg(rdev, "unable to resolve supply\n");

		return 0;
		}

		/**

Admin message