Commit 7dcfb327 authored May 21, 2020 by Dinghao Liu Committed by Mauro Carvalho Chehab Jun 23, 2020

media: staging: tegra-vde: fix runtime pm imbalance on error



pm_runtime_get_sync() increments the runtime PM usage counter even
the call returns an error code. Thus a pairing decrement is needed
on the error handling path to keep the counter balanced.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

parent 0c8bc934

drivers/staging/media/tegra-vde/vde.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -777,7 +777,7 @@ static int tegra_vde_ioctl_decode_h264(struct tegra_vde *vde,

		ret = pm_runtime_get_sync(dev);
		if (ret < 0)
		goto unlock;
		goto put_runtime_pm;

		/*
		* We rely on the VDE registers reset value, otherwise VDE
		@@ -843,8 +843,6 @@ static int tegra_vde_ioctl_decode_h264(struct tegra_vde *vde,
		put_runtime_pm:
		pm_runtime_mark_last_busy(dev);
		pm_runtime_put_autosuspend(dev);

		unlock:
		mutex_unlock(&vde->lock);

		release_dpb_frames:

Admin message