staging: rtl8723bs: remove set but not used variable 'change', 'pos' (7da8abcf) · Commits · 戴 / test

Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c: In function cfg80211_rtw_change_iface: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:1310:5: warning: variable change set but not used [-Wunused-but-set-variable] drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c: In function rtw_cfg80211_set_wpa_ie: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:1803:19: warning: variable pos set but not used [-Wunused-but-set-variable] They are introduced by commit ("staging: Add rtl8723bs sdio wifi driver"), but never used, so remove them. Reported-by:

Hulk Robot <hulkci@huawei.com> Signed-off-by:

zhengbin <zhengbin13@huawei.com> Link: https://lore.kernel.org/r/1574063156-68155-6-git-send-email-zhengbin13@huawei.com Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -1295,7 +1295,6 @@ static int cfg80211_rtw_change_iface(struct wiphy *wiphy,
		struct wireless_dev *rtw_wdev = padapter->rtw_wdev;
		struct mlme_ext_priv *pmlmeext = &(padapter->mlmeextpriv);
		int ret = 0;
		u8 change = false;

		DBG_871X(FUNC_NDEV_FMT" type =%d\n", FUNC_NDEV_ARG(ndev), type);

		@@ -1326,7 +1325,6 @@ static int cfg80211_rtw_change_iface(struct wiphy *wiphy,

		if (old_type != type)
		{
		change = true;
		pmlmeext->action_public_rxseq = 0xffff;
		pmlmeext->action_public_dialog_token = 0xff;
		}
		@@ -1795,7 +1793,7 @@ static int rtw_cfg80211_set_key_mgt(struct security_priv *psecuritypriv, u32 key

		static int rtw_cfg80211_set_wpa_ie(struct adapter padapter, u8 pie, size_t ielen)
		{
		u8 buf = NULL, pos = NULL;
		u8 *buf = NULL;
		int group_cipher = 0, pairwise_cipher = 0;
		int ret = 0;
		int wpa_ielen = 0;
		@@ -1830,7 +1828,6 @@ static int rtw_cfg80211_set_wpa_ie(struct adapter padapter, u8 pie, size_t iel
		DBG_8192C("0x%.2x 0x%.2x 0x%.2x 0x%.2x 0x%.2x 0x%.2x 0x%.2x 0x%.2x\n", buf[i], buf[i+1], buf[i+2], buf[i+3], buf[i+4], buf[i+5], buf[i+6], buf[i+7]);
		}

		pos = buf;
		if (ielen < RSN_HEADER_LEN) {
		RT_TRACE(_module_rtl871x_ioctl_os_c, _drv_err_, ("Ie len too short %d\n", ielen));
		ret = -1;

Admin message