ARM: imx: don't abort MMDC probe if power saving status doesn't match (7d9b8668) · Commits · 戴 / test

The power saving status bit will not signal if the MMDC is under load, which is likely during kernel boot. There is no point in checking this bit and aborting the probe, as there is nothing depending on power saving being enabled, so we can trust the memory controller to enable power saving when we allow it. Signed-off-by:

Lucas Stach <l.stach@pengutronix.de> Signed-off-by:

Shawn Guo <shawnguo@kernel.org>

arch/arm/mach-imx/mmdc.c

+0 −11

Original line number	Diff line number	Diff line
		@@ -547,7 +547,6 @@ static int imx_mmdc_probe(struct platform_device *pdev)
		struct device_node *np = pdev->dev.of_node;
		void __iomem mmdc_base, reg;
		u32 val;
		int timeout = 0x400;

		mmdc_base = of_iomap(np, 0);
		WARN_ON(!mmdc_base);
		@@ -565,16 +564,6 @@ static int imx_mmdc_probe(struct platform_device *pdev)
		val &= ~(1 << BP_MMDC_MAPSR_PSD);
		writel_relaxed(val, reg);

		/* Ensure it's successfully enabled */
		while (!(readl_relaxed(reg) & 1 << BP_MMDC_MAPSR_PSS) && --timeout)
		cpu_relax();

		if (unlikely(!timeout)) {
		pr_warn("%s: failed to enable automatic power saving\n",
		__func__);
		return -EBUSY;
		}

		return imx_mmdc_perf_init(pdev, mmdc_base);
		}

Admin message