Commit 7d9b62ae authored Feb 14, 2019 by David Kozub Committed by Jens Axboe Apr 06, 2019

block: sed-opal: unify error handling of responses



response_get_{string,u64} include error handling for argument resp being
NULL but response_get_token does not handle this.

Make all three of response_get_{string,u64,token} handle NULL resp in
the same way.

Co-authored-by: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
Signed-off-by: David Kozub <zub@linux.fjfi.cvut.cz>
Signed-off-by: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
Reviewed-by: Scott Bauer <sbauer@plzdonthack.me>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Jon Derrick <jonathan.derrick@intel.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent e8b29224

block/sed-opal.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -696,6 +696,11 @@ static const struct opal_resp_tok *response_get_token(
		{
		const struct opal_resp_tok *tok;

		if (!resp) {
		pr_debug("Response is NULL\n");
		return ERR_PTR(-EINVAL);
		}

		if (n >= resp->num) {
		pr_debug("Token number doesn't exist: %d, resp: %d\n",
		n, resp->num);

Admin message