Commit 7d8f9f7d authored by Theodore Ts'o's avatar Theodore Ts'o
Browse files

ext4: Automatically allocate delay allocated blocks on close 



When closing a file that had been previously truncated, force any
delay allocated blocks that to be allocated so that if the filesystem
is mounted with data=ordered, the data blocks will be pushed out to
disk along with the journal commit.  Many application programs expect
this, so we do this to avoid zero length files if the system crashes
unexpectedly.

Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
parent ccd2506b

fs/ext4/ext4.h

+1 −0
Original line number Diff line number Diff line
@@ -270,6 +270,7 @@ static inline __u32 ext4_mask_flags(umode_t mode, __u32 flags) 
#define EXT4_STATE_NEW			0x00000002 /* inode is newly created */

#define EXT4_STATE_XATTR		0x00000004 /* has in-inode xattrs */

#define EXT4_STATE_NO_EXPAND		0x00000008 /* No space for expansion */

#define EXT4_STATE_DA_ALLOC_CLOSE	0x00000010 /* Alloc DA blks on close */



/* Used to pass group descriptor data when online resize is done */

struct ext4_new_group_input {

fs/ext4/file.c

+4 −0
Original line number Diff line number Diff line
@@ -33,6 +33,10 @@ 
 */

static int ext4_release_file(struct inode *inode, struct file *filp)

{

	if (EXT4_I(inode)->i_state & EXT4_STATE_DA_ALLOC_CLOSE) {

		ext4_alloc_da_blocks(inode);

		EXT4_I(inode)->i_state &= ~EXT4_STATE_DA_ALLOC_CLOSE;

	}

	/* if we are the last writer on the inode, drop the block reservation */

	if ((filp->f_mode & FMODE_WRITE) &&

			(atomic_read(&inode->i_writecount) == 1))

fs/ext4/inode.c

+3 −0
Original line number Diff line number Diff line
@@ -3901,6 +3901,9 @@ void ext4_truncate(struct inode *inode) 
	if (!ext4_can_truncate(inode))

		return;



	if (inode->i_size == 0)

		ei->i_state |= EXT4_STATE_DA_ALLOC_CLOSE;



	if (EXT4_I(inode)->i_flags & EXT4_EXTENTS_FL) {

		ext4_ext_truncate(inode);

		return;

CRA Git | Maintained and supported by SUSTech CRA and CCSE